This repository was archived by the owner on Oct 9, 2020. It is now read-only.
[fix] don't transform webpack2 query objects#44
Merged
sairion merged 1 commit intowebpack-contrib:masterfrom Dec 15, 2016
Merged
[fix] don't transform webpack2 query objects#44sairion merged 1 commit intowebpack-contrib:masterfrom
sairion merged 1 commit intowebpack-contrib:masterfrom
Conversation
Collaborator
|
Thanks! |
Contributor
Author
|
Thank you! Can you please publish this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack2 supports query objects which are returned by parseQuery, not a new object instance.
https://github.com/webpack/loader-utils/blob/master/index.js#L68
Because of this, we shouldn't transform the parseQuery result directly which is what this PR addresses.